Add __getattr__ support to PR 2904
#2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew-S-Rosen
changed the title
__getattr__ to PR 2904__getattr__ support to PR 2904
|
I was thinking about how maybe this should try to avoid methods beginning with |
|
I do think some sort of guardrails could be useful. In addition, should we also explicitly avoid methods that are already part of the |
|
I think |
|
Ah, of course. Yes yes! You are correct 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@benclifford: This adds
__getattr__support to #2904. If all goes as it does locally for me, then these tests should pass.I also added tests for
__getitem__withlistandtupleresults.Edit: Looks like
parsl/tests/test_python_apps/test_lifted.pytests passed, but I'm not sure what the other failures are from.